Only allow HTTP adapters for codecompanion result summarisation#278
Merged
Only allow HTTP adapters for codecompanion result summarisation#278
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 24 24
Lines 1788 1788
=======================================
Hits 1782 1782
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6e7b933 to
bac14ea
Compare
bac14ea to
1d12003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of olimorris/codecompanion.nvim#2030, which introduces ACP adapters alongside the regular HTTP adapters. Since the ACP adapters don't share the same interface as the HTTP adapters, it's easier to only allow HTTP adapters to be used here. This is mostly a fail-safe, because the ACP adapters don't use the codecompanion tools OOTB (?).