[Pending] PC view of DeckEditor (copy old) #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
标题 duplicate 有点怪，copy ？ |
webxoss
reviewed
Aug 26, 2017
src/store.js
Outdated
|
|
||
| shownPid: 1, | ||
|
|
||
| // recently the pid deleted card |
Collaborator
There was a problem hiding this comment.
Recently deleted card 吧？
话说 Last 比较合适的感觉
| }, | ||
| hover() { | ||
| // 节流 | ||
| this.$store.commit('setShownPid', this.card.pid) |
webxoss
reviewed
Aug 26, 2017
Collaborator
webxoss
left a comment
webxoss
left a comment
There was a problem hiding this comment.
先合导入导出的吧，PC 的到可对外使用才合到 master
Deardrops
commented
Aug 26, 2017
src/components/Block.vue
Outdated
| <script> | ||
| import { mapGetters } from 'vuex' | ||
| import CardImage from 'components/CardImage' | ||
| import _ from lodash |
Deardrops
force-pushed
the
duplicate-deckeditor
branch
3 times, most recently
from
3a306cc to
df6814d
Compare
webxoss
reviewed
Aug 27, 2017
src/lang/en.hjson
Outdated
| export_to: export to | ||
|
|
||
| // toast | ||
| deck_filled: Deck has already been filled. |
Collaborator
There was a problem hiding this comment.
什么鬼😂
用 exceeded
Deck limit exceeded
src/lang/en.hjson
Outdated
|
|
||
| // toast | ||
| deck_filled: Deck has already been filled. | ||
| export_succussed: Export current deck succussed. |
Collaborator
There was a problem hiding this comment.
每次看到我们产品中提示“xx操作已成功完成”“消息已成功发出”的“成功”二字，我就很头大，说了很多次还是出现，今天就下死命令产品中不可以再出现“成功”二字。我有文字洁癖，还是走火入魔了。“消息已成功发出”，搞得好像还有不成功发出的消息似的。
——张小龙
src/lang/en.hjson
Outdated
| // toast | ||
| deck_filled: Deck has already been filled. | ||
| export_succussed: Export current deck succussed. | ||
| deck_copied: deck copied to clipboard. |
Collaborator
There was a problem hiding this comment.
我觉得简洁点 Copied 就行。
话说首字母大写
src/pages/DeckEditor.vue
Outdated
| Toast, | ||
| }, | ||
| data: () => ({ | ||
| queryString: 's', |
webxoss
reviewed
Aug 27, 2017
src/lang/en.hjson
Outdated
| export_to: export to | ||
|
|
||
| // toast | ||
| exceeded: Deck limit exceeded. |
Collaborator
There was a problem hiding this comment.
额、字段不能光是 exceeded 吧，后面有别的超出呢。。。
Deardrops
force-pushed
the
duplicate-deckeditor
branch
from
7a16a0c to
02ccc7f
Compare
Deardrops
force-pushed
the
duplicate-deckeditor
branch
from
02ccc7f to
5ed094f
Compare
Deardrops
changed the title
Deardrops
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: