-
Notifications
You must be signed in to change notification settings - Fork 4
[dmm] initial multimeter frontend #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kyatsen
commented
Jan 6, 2026
Copy-paste from lvgl/lv_port_linux and remove irrelevant files.
s8nik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job.
honesty, the pr is difficult to review, it would be better to split it next time. for this case it could be split into 3 parts:
- project setup
- fonts and icons sources
- code part
also, i think we should remove a lot of the general codebase + configs and only keep what is needed.
while i agree that it’s much easier to review per commit, thought in the end everything gets squashed into one large commit on main (which is not good imho). even reviewing it per commit can still be a bit overwhelming since the commits are quite large, it would be even better to split those commits by smaller parts :D
hmm for testing purposes, it’s fine to keep different backends if needed, but in the end we should clean this up (honestly, i don’t think there are test scenarios for all of them). my point is that for a standalone app, it makes sense to support all possible backends. but for a specific app that will run only on a specific device, it adds a lot of noise, and most of the general code becomes effectively dead code. since the app’s code will be very specific (it will read data from the |
|
@s8nik yeap, I agree, next time will split by MRs, but this is the only big MR for this app. |
s8nik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
