Changed ViewControllerLifecycle implementation using swizzling
#708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR changes
ViewControllerLifecycleimplementation to a swizzling based approach because I noticed some issues with the existing child view controller approach:UINavigationControllerand you start observing the events on it, therootViewControllerof the navigation controller will be swapped with aWrapperViewControllerresulting in an empty view.TabBarControlleris potentially open to same type of issue.childrenarray could become hard to manage.WrapperViewControlleras child, the stack trace messages become hard to understand because of theseWrapperViewControllernoise.I don't like that this solution is based on swizzling but I believe there's no easy way to address this without creating a base
UIViewControllersubclass that all the other VCs have to subclass.This piece of code was also untested and I added some tests on top of it now, let me know if you see any issue!
cc @ibrahimkteish