You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The 3D conformer coordinates are used in various model(SchNet, DimeNet, SpereNet, Graphormer).
Conformer generation code is added to contribute to more various model.
There are several methods of generating conformer provided by rdkit, but for now, the MMFF method was used.
Thanks! That's a good initiative. 3D conformers are really important for a wide range of tasks and models.
As conformer is not a necessary attribute to reconstruct a RDKit molecule, I would suggest reconsidering if we should put it as a precomputed attribute in data.Molecule.from_smiles or as a lazy attribute like data.Molecule.is_valid_rdkit. Additionally, providing an interface for different conformation generation methods would be nice.
We would come back to update your code and merge it.
I considered because the conformer generation provided by Rdkit was not an accurate value.
Currently, I'm considering about implemented two versions of the conformers using rdkit's forcefield and the conformers calculated directly by the user through external software!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3D conformer coordinates are used in various model(SchNet, DimeNet, SpereNet, Graphormer).
Conformer generation code is added to contribute to more various model.
There are several methods of generating conformer provided by rdkit, but for now, the MMFF method was used.