Adding optional parameter to add a default a-tag class to the MvcLink…

[royhyde-dd]

… if the linkField does not have one defined. Fixing string comparisons so a-tag and alternateTags are created correctly.

[hollywoodinvegas]

If the LinkField has a Class property already why do we need this extra property?
The property should be called linkClass not linkTagClass if it's actually needed to be consistent with the rest of the fields.
If we do need the property could we use the value in the "linkTagClass" and add it to the linkField before calling MvcLink?

[hollywoodinvegas]

@royhyde-dd please update the version in the csproj file to be 2.1.0.0 so that we can use this as a basis for a new nuget package

[royhyde-dd]

If the LinkField has a Class property already why do we need this extra property?
The property should be called linkClass not linkTagClass if it's actually needed to be consistent with the rest of the fields.
If we do need the property could we use the value in the "linkTagClass" and add it to the linkField before calling MvcLink?

@hollywoodinvegas, in some cases, we want to add a class without the user needing to add a class. It is to resolve https://hub.deloittedigital.com.au/jira/browse/DSP-136. In that case, the class cm-image-block-link needs to be added to the a-tag for the link to render correctly.

[hollywoodinvegas]

Happy for this to be merged, @royhyde-dd can you follow up on how we push this to nuget as version 2.1.0.0

[mt-dd]

I think the behaviour here is a little weird as it'll use either the link's class or the supplied class. If a class is provided via linkTagClass but the content author already included a class, the linkTagClass value won't show up.

If both fields have a value should this create a HashSet<string> to split, merge, then re-join the two class inputs, and render that out as the final class string?

[hollywoodinvegas]

If both are set should we use both or does one override? In which case we should call the field defaultClass or overrideClass usually the FEDs are pretty good with stacking so you. Can probably just add both classes