Skip to content

Other field changes should not biography_last_updated timestamp#2212

Merged
VirginiaDooley merged 1 commit intomasterfrom
hotfix/test-biography-membership-update
Jan 25, 2024
Merged

Other field changes should not biography_last_updated timestamp#2212
VirginiaDooley merged 1 commit intomasterfrom
hotfix/test-biography-membership-update

Conversation

@VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Dec 21, 2023 •
edited
Loading

This change ensures biography time stamp is only be updated with a change in form data in the biography field.

@VirginiaDooley VirginiaDooley marked this pull request as ready for review December 21, 2023 18:54
@VirginiaDooley VirginiaDooley requested a review from symroe January 4, 2024 11:09
@pmk01
Copy link
Contributor

pmk01 commented Jan 15, 2024

From @sjorford:
it seems to be wrong more often than not? a couple of examples:
https://candidates.democracyclub.org.uk/person/72914/jack-thomson
https://candidates.democracyclub.org.uk/person/19009/preet-kaur-gill
https://candidates.democracyclub.org.uk/person/20/captain-beany
https://candidates.democracyclub.org.uk/person/1412/guto-bebb

@VirginiaDooley VirginiaDooley force-pushed the hotfix/test-biography-membership-update branch from 67ae0ea to 185d35a Compare January 15, 2024 20:01
@VirginiaDooley
Copy link
Contributor Author

VirginiaDooley commented Jan 15, 2024

From @sjorford: it seems to be wrong more often than not? a couple of examples: https://candidates.democracyclub.org.uk/person/72914/jack-thomson https://candidates.democracyclub.org.uk/person/19009/preet-kaur-gill https://candidates.democracyclub.org.uk/person/20/captain-beany https://candidates.democracyclub.org.uk/person/1412/guto-bebb

The issue here is that "biography" is included in changed_data even when there has not been a change to the biography. The bug seems to occur most often (?) when a candidacy is added to a person.

@VirginiaDooley VirginiaDooley force-pushed the hotfix/test-biography-membership-update branch 3 times, most recently from c5d6fdb to c6c4835 Compare January 16, 2024 13:16
@VirginiaDooley VirginiaDooley force-pushed the hotfix/test-biography-membership-update branch 2 times, most recently from 2509827 to ad38726 Compare January 16, 2024 13:35
@VirginiaDooley VirginiaDooley changed the title Test list position change doesn't effect biography_last_updated times… Other field changes should not biography_last_updated timestamp Jan 16, 2024
@VirginiaDooley VirginiaDooley force-pushed the hotfix/test-biography-membership-update branch from ad38726 to 0a22f1a Compare January 18, 2024 13:15
@VirginiaDooley VirginiaDooley force-pushed the hotfix/test-biography-membership-update branch from 0a22f1a to 08c2049 Compare January 18, 2024 15:59
symroe
symroe approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@symroe symroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really confused as to why changed_data isn't acting as documented...I thought it would only be in the list if something had actually changes.

Either way, this fix seems like the best approach, given the oddities!

@VirginiaDooley VirginiaDooley merged commit be78c00 into master Jan 25, 2024
@VirginiaDooley VirginiaDooley mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@symroe symroe symroe approved these changes

@GeoWill GeoWill Awaiting requested review from GeoWill

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VirginiaDooley @pmk01 @symroe