Conversation
chris48s
reviewed
Aug 7, 2024
Member
chris48s
left a comment
chris48s
left a comment
There was a problem hiding this comment.
I haven't run this code locally, but I've had a quick read over the diff. Here's a few thoughts..
ynr/apps/people/management/commands/reformat_person_identifiers.py
Outdated
Show resolved
Hide resolved
ynr/apps/people/management/commands/reformat_person_identifiers.py
Outdated
Show resolved
Hide resolved
Member
|
Oh, and your build is ❌ failing 😆 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Audit all person identifiers and their validation - Check the domain and the username for valid entries
symroe
force-pushed
the
person-identifier-cleaning
branch
from
0a7329a to
6327f12
Compare
Member
Author
|
Ok, I reckon that's all of those comments addressed? |
chris48s
approved these changes
Aug 7, 2024
Member
chris48s
left a comment
chris48s
left a comment
There was a problem hiding this comment.
Latest changes look pretty sensible. Ta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines and replaces #2400 and #2406 into one PR.
I combined them because both PRs contained the same management command with different code in it. I decided to re-write it to make it more generic.
I also did some cleaning up of the validation and cleaning code.
Tested on a staging copy of the database.