Conversation
|
Having deleted all this code, are we now in a position to remove One thing we lose by removing the Camelot backend is the ability to have a "working" local application with out connecting it to AWS. That doesn't mean we should keep Camelot, but do you think there is any mileage in having a "mock" PDF parsing backend? I am thinking we write a "parser" where you feed it any PDF and it throws the PDF away and just returns the same hard-coded list of people/parties. Worth bothering with? There's a code formatting error to resolve with ruff to get the build passing. |
|
|
||
| .PHONY: populate-sopn-testing-database | ||
| populate-sopn-testing-database: migrate-db | ||
| python manage.py candidates_import_from_live_site |
There was a problem hiding this comment.
This is a bit of a tangent, but while we're getting trigger happy with the delete button, shall we bin candidates_import_from_live_site too? I reckon now we have https://github.com/DemocracyClub/yournextrepresentative/blob/master/scripts/get-prod-db.sh this is basically just going to rot.
|
Quick thing I noticed while working on something else.. decorator on them. Can you double-check if that is something we can get rid of as part of this PR. |
This was used to capture baselines for Camelot. We no longer need this code
This is a bit of a tangle to remove cleanly. I think I've removed too much, especially some of the tests that really should be converted to use AWS Textract rather than just removing them. The plan is to built these up again with a bit of a rethink / redesign of the whole system. Maintaining these tests while refactoring wouldn't be a good idea, so I suggest revisiting them later.
02890ce to
a5b245d
Compare
Now we're in a container, we don't need to skip these tests
There was a problem hiding this comment.
I think we're getting a bit delete-happy on useful tests here.
As I've been working on #2639 I have found that the tests in this file are mostly relevant and I've found myself updating them as I go. For example there are big chunks of tests in here that are about how we parse names that are equally relevant to both textract and camelot.
Can you restore this file and go through it just removing the ones that are specific to camelot. I think we will end up keeping much of this.
In this PR I do a couple of things:
A couple of extra points: