Support for adding multiple resource packs #2791
Open
+97
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ive moved remove function to the command itself as requested |
tal5
requested changes
Jan 12, 2026
| player.setResourcePack(url, CoreUtilities.toLowerCase(hash), forced, PaperModule.parseFormattedText(prompt, ChatColor.WHITE)); | ||
| } | ||
| else { | ||
| player.setResourcePack(ResourcePackCommand.parseUUID(id), url, CoreUtilities.toLowerCase(hash), PaperModule.parseFormattedText(prompt, ChatColor.WHITE), forced); |
Member
There was a problem hiding this comment.
You parse id into a UUID multiple times across the code, I'd just do it once before the whole switch and then pass it here as a UUID already.
|
|
||
| public static boolean checkOnline(PlayerTag player) { | ||
| if (!player.isOnline()) { | ||
| Debug.echoError("Invalid player '" + player.getName() + "' specified: must be online"); |
| UUID packUUID = id == null ? UUID.nameUUIDFromBytes(url.getBytes(StandardCharsets.UTF_8)) : parseUUID(id); | ||
| for (PlayerTag player : targets) { | ||
| if (checkOnline(player)) { | ||
| player.getPlayerEntity().addResourcePack(packUUID, url, hashData, prompt, forced); |
Member
There was a problem hiding this comment.
This needs a paper impl as well, otherwise some parts of the command support advanced text and some wont which might be a bit confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continued work of #2712
Additions:
addinresourcepackcommand to send player additional resourcepacks.PlayerTag.remove_resource_packto remove resourcepack by ID from playerPlayerTag.remove_resource_packsto remove all resourcepacks from player