Title command fix #2806
Merged
Title command fix #2806
+6
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
requested changes
Jan 13, 2026
Comment on lines
164
to
165
| new ClientboundSetTitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(title == null ? "" : title , ChatColor.WHITE))), | ||
| new ClientboundSetSubtitleTextPacket(Handler.componentToNMS(FormattedTextHelper.parse(subtitle == null ? "" : subtitle, ChatColor.WHITE))) |
Member
There was a problem hiding this comment.
Why is the defaulting done here instead of in TitleCommand's existing method (I.e. the new parse thing) - instead of having the command default to null and then default null to a string here just have the command default to a string.
tal5
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they need to be sent together, reported in https://discord.com/channels/315163488085475337/1460651333567910002