Skip to content

Conversation

@zer0uno
Copy link

@zer0uno zer0uno commented Aug 10, 2025

Removed workaround for OssIndexAnalysis when component had "v" as version prefix

Description

I've noticed that calling the OSS Index API https://ossindex.sonatype.org/api/v3/component-report with pkg:composer/symfony/validator@v3.3.18 correctly returns the vulnerability CVE-2024-50343, while calling the API with pkg:composer/symfony/validator@3.3.18 (note the absence of v) I get back no vulnerability.
In the OssIndexAnalysisTask class I found that the minimizePurl() method removes the v just before calling the API, apparently because previously there was a bug (as explained in the comment block above the function definition) that now seems solved.

Addressed Issue

#1220

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Removed workaround for OssIndexAnalysis when component had "v" as version prefix

Signed-off-by: zeroUno <antocota91@gmail.com>
@owasp-dt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@agnieszka-docplanner
Copy link

Hi, any progress on this? There is a lot of components with "v" in version and they are currently not being properly analyzed.

@nscuro
Copy link
Member

nscuro commented Nov 14, 2025

Here's a related Slack discussion: https://owasp.slack.com/archives/C6R3R32H4/p1754692145518059

I am not confident removing this logic for all ecosystems will yield the desired result, as in some cases adding the v will cause all vulnerabilities across all versions to be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants