Skip to content

Conversation

@Phyrone
Copy link

@Phyrone Phyrone commented Jan 4, 2023

  • kick player using cloudnet v4 instant of bungeecord (like version 3 and 2 support)
    • fix player not kicked when using cloudnet v4
  • updated maven dependencies necessary to compile

CloudnetV4 is at the moment of this pull request still in release candidate state. It's still possible that the API changes, however I consider it as very unlikely.

@DevLeoko
Copy link
Owner

DevLeoko commented Jan 4, 2023

Looks good - has this been tested with the latest CloudNet V4 build?

@Phyrone
Copy link
Author

Phyrone commented Jan 4, 2023

I installed it on my network(which is v4 - rc5) for a few hours now, and it works fine so far.

@Phyrone
Copy link
Author

Phyrone commented Jan 4, 2023

However cloudnet v4 uses adventure text, and I was not sure first, how to convert.
I used legacy next convert for (like bungeecord TextComponent.fromLeagytext) now. I think that's the correct one.

DevLeoko
DevLeoko previously approved these changes Jan 7, 2023
Copy link
Owner

@DevLeoko DevLeoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contibution

@DevLeoko
Copy link
Owner

DevLeoko commented Jan 7, 2023

Seems like something with the Cloudnet V4 dependency is wrong (see automated test)

@Phyrone
Copy link
Author

Phyrone commented Jan 7, 2023

Looks like cloudnet 4 requires at least java 17 meanwhile advancedbans still compiles on java 1.8.
i dont know how to solve this without upgrading advancedbans to java 17

@Hopefuls Hopefuls dismissed DevLeoko’s stale review March 27, 2025 21:20

Failed build, refer to later comments

@Hopefuls
Copy link
Collaborator

Is there a solution to this? We may have to "bite the bullet" and consider AdvancedBan to bump to a newer version required. This will break backwards-compatibility, unless theres a better solution to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants