-
Notifications
You must be signed in to change notification settings - Fork 128
Add CloudnetV4 support and maven depedency fix #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Looks good - has this been tested with the latest CloudNet V4 build? |
|
I installed it on my network(which is v4 - rc5) for a few hours now, and it works fine so far. |
|
However cloudnet v4 uses adventure text, and I was not sure first, how to convert. |
DevLeoko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contibution
|
Seems like something with the Cloudnet V4 dependency is wrong (see automated test) |
|
Looks like cloudnet 4 requires at least java 17 meanwhile advancedbans still compiles on java 1.8. |
Failed build, refer to later comments
|
Is there a solution to this? We may have to "bite the bullet" and consider AdvancedBan to bump to a newer version required. This will break backwards-compatibility, unless theres a better solution to this. |
CloudnetV4 is at the moment of this pull request still in release candidate state. It's still possible that the API changes, however I consider it as very unlikely.