Allow players to view their full /history #626
Conversation
Didnt want the same thing to be repeated a third time so i made a method and named it an absolutely wrong name but cant thing of a a good name so i am leaving it with a bad until feedback
I initially wrote this before I updated the branch "Full History", so it made more sense to have an array. So I rearranged it to better match the layout in PunishmentManager
I missed that error, but saw in the maven check that it failed because of it
I didnt say true when it was history so it was just throwing all the errors
Hopefuls
left a comment
Hopefuls
left a comment
There was a problem hiding this comment.
Please refer to the comments provided in this review.
| import java.util.Calendar; | ||
| import java.util.GregorianCalendar; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
Please define the imports required that are relevant for the changes rather than using a wildcard.
| HISTORY("ab.history", | ||
| "\\S+( [1-9][0-9]*)?", | ||
| HISTORY(null, | ||
| "\\S+( [1-9][0-9]*)?|\\S+|", |
There was a problem hiding this comment.
Can you clarify this change?
There was a problem hiding this comment.
Why I did it this way, I have no idea, as it has been like two years.
But it seems like it is because because I split up the self history's own perm.
|
The requested change couldn't happen because it no longer existed likely due to the outdated tag |
|
Could you revise your changes to the state of development-future? If you wish to continue working on this. Otherwise I might close this pull request |
|
Let me check out that branch, and I will respond again within a week. I don't imagine it will be difficult, but I don't have the same development and test environment as when I originally worked on it. |
|
Yeah my time over the next week or so hasn't cleared up. |
2 participants
This allows a user to view their own history. I didn't want the same thing to be repeated a third time so i made a method .
I couldn't for the life of me come up with a good name for the method, so I left it at the working name for making sure it all worked.
#326 #556