Substring Extractor#533
Open
Manasi2001 wants to merge 1 commit intoDeveloper-Student-Clubs-VSSUT-Burla:mainfrom
Manasi2001:issue-521
Open
Substring Extractor#533Manasi2001 wants to merge 1 commit intoDeveloper-Student-Clubs-VSSUT-Burla:mainfrom Manasi2001:issue-521
Manasi2001 wants to merge 1 commit intoDeveloper-Student-Clubs-VSSUT-Burla:mainfrom
Manasi2001:issue-521
Conversation
Sin-Sumit
suggested changes
Aug 10, 2021
Sin-Sumit
left a comment
Sin-Sumit
left a comment
There was a problem hiding this comment.
1.This is not correct because after appending the names in the list then you have to move out from the for loop then perform the sorted and printing.
2.This way it is taking the names and printing them with a single element and keep adding to it.
3. Complexity is not O(N) and O(1) because sorting takes NlogN time and you are using the space as a list which is O(N).
4. Please do above changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is with reference to issue #521.