Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 87.71% 87.75% +0.03%
==========================================
Files 31 31
Lines 1343 1347 +4
==========================================
+ Hits 1178 1182 +4
Misses 165 165 ☔ View full report in Codecov by Sentry. |
GDYendell
reviewed
Jan 27, 2025
GDYendell
previously approved these changes
Jan 27, 2025
2540126 to
1fc762a
Compare
GDYendell
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
get_controller_schemafunction that can be convenient for assessing the schema of a controller - useful for the testing of a FastCS project. Another benefit is that thetests/data/schema.jsonis now also assessed by the new test - so the test will fail if its not kept up to date