Skip to content

fix: Exposed submodules in fastcs.__init__#139

Merged
evvaaaa merged 2 commits intomainfrom
expose-submodules-in-fastcs-init
Mar 19, 2025
Merged

fix: Exposed submodules in fastcs.__init__#139
evvaaaa merged 2 commits intomainfrom
expose-submodules-in-fastcs-init

Conversation

@evvaaaa
Copy link
Contributor

@evvaaaa evvaaaa commented Mar 18, 2025

We can avoid circular imports in typing by importing from the module.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (5aa7a12) to head (c14df49).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/transport/epics/pva/types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files          41       41           
  Lines        1933     1935    +2     
=======================================
+ Hits         1751     1753    +2     
  Misses        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evvaaaa evvaaaa marked this pull request as draft March 18, 2025 11:05
@evvaaaa evvaaaa requested a review from GDYendell March 18, 2025 13:32
evvaaaa added 2 commits March 18, 2025 13:39
We can avoid circular imports in typing by importing from the module.
@evvaaaa evvaaaa force-pushed the expose-submodules-in-fastcs-init branch from 3d935ef to c14df49 Compare March 18, 2025 13:43
@evvaaaa evvaaaa marked this pull request as ready for review March 18, 2025 13:43
@evvaaaa evvaaaa linked an issue Mar 18, 2025 that may be closed by this pull request
@evvaaaa
Copy link
Contributor Author

evvaaaa commented Mar 18, 2025

image

@evvaaaa evvaaaa merged commit 1cce8ea into main Mar 19, 2025
18 checks passed
@evvaaaa evvaaaa deleted the expose-submodules-in-fastcs-init branch March 19, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse API in docs

2 participants