Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 90.81% 91.84% +1.02%
==========================================
Files 41 40 -1
Lines 1971 1961 -10
==========================================
+ Hits 1790 1801 +11
+ Misses 181 160 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds demo and tutorial components for showcasing FastCS functionality while also updating backend linking for improved sub-controller resolution and adjusting project configurations accordingly.
- Removed CLI tests and legacy CLI module.
- Introduced demo simulation, device, and controller files.
- Updated backend linking to correctly resolve sub-controller paths and adjusted project configurations (dependencies, docs, workflows).
Reviewed Changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_cli.py | Removal of CLI test code |
| tests/test_backend.py | Addition of new backend linking tests |
| src/fastcs/transport/epics/gui.py | Minor update with type ignore comment |
| src/fastcs/launch.py | Updated import for version |
| src/fastcs/demo/simulation/temp_controller.yaml | New simulation configuration file |
| src/fastcs/demo/simulation/device.py | New device simulation code with ramp and update methods |
| src/fastcs/demo/controllers.py | New demo controllers and handler implementations |
| src/fastcs/demo/controller.yaml | New demo controller configuration |
| src/fastcs/demo/main.py | New demo module entry point |
| src/fastcs/datatypes.py | Updated error message formatting |
| src/fastcs/controller.py | Added sub-controller access via getitem |
| src/fastcs/backend.py | Updates to attribute linking and scan task scheduling |
| src/fastcs/main.py | Removed legacy CLI module |
| pyproject.toml | Updated dependencies and test coverage omit paths |
| docs/conf.py | Updated nitpick ignore regex and logo |
| .github/workflows/_dist.yml | Updated workflow step for testing version |
Files not reviewed (2)
- .vscode/launch.json: Language not supported
- src/fastcs/demo/schema.json: Language not supported
Comments suppressed due to low confidence (1)
src/fastcs/demo/simulation/device.py:107
- [nitpick] Although functionally equivalent, consider replacing 'sum(self.get_voltages() * 50)' with '50 * sum(self.get_voltages())' to make the intent clearer.
return sum(self.get_voltages() * 50)
|
It shouldn't be including the demo directory in coverage. The |
bb0ce27 to
d732972
Compare
a287dbf to
4f9d692
Compare
186464b to
33ebfe6
Compare
ajgdls
left a comment
There was a problem hiding this comment.
Installed and tested the applications.
Detect start better tickit does not stop cleanly on python 3.12 so kill process
No description provided.