Allow creating CA IOCs via yaml config#158
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 40 40
Lines 1962 1962
=======================================
Hits 1800 1800
Misses 162 162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make CA and PVA options models unique so that they can be distinguised in the yaml config. Fix demo PV prefix.
GDYendell
force-pushed
the
epics-options-models
branch
from
155aa51 to
5ea717f
Compare
LuisFSegalla
approved these changes
May 27, 2025
Contributor
LuisFSegalla
left a comment
LuisFSegalla
left a comment
There was a problem hiding this comment.
Seems good to me!
Managed to run all the tests and couldn't find anything wrong or that needed change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables creating either ca or pva IOCs via yaml config by giving them uniquely named fields.
Fixes #145