Log exception in scan and command methods#162
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 92.22% 92.24% +0.02%
==========================================
Files 40 40
Lines 2070 2077 +7
==========================================
+ Hits 1909 1916 +7
Misses 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Returning to this PR, it seems that the current state is that command's that raise exceptions are printed to the terminal. So, we can remove the specific print statement I added in pva. Scan routines that raise exceptions are not printed without the changes introduced in this PR, so that should stay. |
|
I've brought the branch back up to date, so I'm re-requesting a review. I could not reproduce having a |
Fixes #146
This PR adds a callback to scan coroutines that raises their exception if they fail.
SoftIOCcommand exceptions were already being displayed on terminal, whereasp4pcommand exceptions were not; these tracebacks are now printed to terminal.