Skip to content

Add table support in pva and fix gui pv naming#167

Merged
GDYendell merged 13 commits intomainfrom
pvi_gui
Jul 24, 2025
Merged

Add table support in pva and fix gui pv naming#167
GDYendell merged 13 commits intomainfrom
pvi_gui

Conversation

@shihab-dls
Copy link
Contributor

@shihab-dls shihab-dls commented Jul 7, 2025

#Fixes #166
This PR adds PvaEpicsGui, which allows tables and prepends pva:// to pvs to allow access to pva signals via the GUI. Tables already have this added, so this issue in pvi should be merged.

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (aec213b) to head (a37abf2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/transport/epics/gui.py 93.93% 2 Missing ⚠️
src/fastcs/transport/epics/pva/adapter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   92.27%   92.28%   +0.01%     
==========================================
  Files          40       40              
  Lines        1980     2009      +29     
==========================================
+ Hits         1827     1854      +27     
- Misses        153      155       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls requested a review from GDYendell July 18, 2025 15:16
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things

@shihab-dls shihab-dls requested a review from GDYendell July 23, 2025 15:46
@GDYendell GDYendell merged commit 3ec51ea into main Jul 24, 2025
18 checks passed
@GDYendell GDYendell deleted the pvi_gui branch July 24, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Table widgets work for EPICS gui generation

2 participants