Skip to content

assert hinted attrs are bound and have right dtype after initialisation#187

Merged
GDYendell merged 5 commits intomainfrom
hint-dynamic-attrs
Aug 14, 2025
Merged

assert hinted attrs are bound and have right dtype after initialisation#187
GDYendell merged 5 commits intomainfrom
hint-dynamic-attrs

Conversation

@jsouter
Copy link
Contributor

@jsouter jsouter commented Aug 12, 2025

Closes #125
Closes #124

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.25%. Comparing base (ff0be1d) to head (91a7c41).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/util.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   92.19%   92.25%   +0.05%     
==========================================
  Files          40       40              
  Lines        2012     2040      +28     
==========================================
+ Hits         1855     1882      +27     
- Misses        157      158       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsouter jsouter force-pushed the hint-dynamic-attrs branch from f647966 to 86fd396 Compare August 12, 2025 09:30
@jsouter jsouter requested a review from GDYendell August 12, 2025 10:11
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

I don't love that this check is done by Backend, but I think this can be improved later. When we create an add_attribute method for creating dynamic attributes that would be a good hook to do this check.

@GDYendell GDYendell merged commit 64a7828 into main Aug 14, 2025
18 checks passed
@GDYendell GDYendell deleted the hint-dynamic-attrs branch August 14, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants