Conversation
first pass at helm chart for fastcs instances fix service name better port exposure for service.yaml add helm chart publishing remove service account creation from helm switch to using Charts folder with subfolders for charts add schema for fastcs-instance chart values.yaml publish chart values schemas publish chart values schemas add schema generation to pre-commit fixing the fastcs-instance chart schema add debug features to helm chart repair incorrect helm chart debug now working fix non-debug mode fix incorrect terminationGracePeriodSeconds add debug entrypoint move initCommand into values rename charts to remove "instance"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 40 40
Lines 2077 2077
=======================================
Hits 1916 1916
Misses 161 161 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@GDYendell I believe this is ready now. I have added a little documentation here https://github.com/DiamondLightSource/FastCS/blob/switch-schema-squash/Charts/README_CHARTS.md @DiamondJoseph I would be interested in your opinion on the README above. At some point I'd like to take your work and/or this work and apply it into BTW this represents our first transition to use of the same schema generator as DAQ. I have one outstanding issue with it that I consider minor, which is losisin/helm-values-schema-json#251 (comment) |
gilesknap
left a comment
gilesknap
left a comment
There was a problem hiding this comment.
I've made a commit to fix the majority of Gary's comments
|
All issues resolved. Ready to merge? @GDYendell |
2 participants
No description provided.