Skip to content

Fix softioc system test#229

Merged
GDYendell merged 5 commits intomainfrom
fix-tests
Oct 17, 2025
Merged

Fix softioc system test#229
GDYendell merged 5 commits intomainfrom
fix-tests

Conversation

@jsouter
Copy link
Contributor

@jsouter jsouter commented Oct 6, 2025

Closes #228

Small fix needed due to changes in logging messages that softioc system tests wait for before timing out. Also have removed src from the doctests for now as the Tracer docstring was being collected and failing under pytest.

@jsouter jsouter requested a review from GDYendell October 6, 2025 15:05
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.59%. Comparing base (9c2042a) to head (b947783).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/fastcs/launch.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   92.34%   88.59%   -3.76%     
==========================================
  Files          40       44       +4     
  Lines        2077     2253     +176     
==========================================
+ Hits         1918     1996      +78     
- Misses        159      257      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell
Copy link
Contributor

I think the coverage failure is not reliable because the tests are broken on main anyway.

@GDYendell GDYendell merged commit 51292cf into main Oct 17, 2025
9 of 12 checks passed
@GDYendell GDYendell deleted the fix-tests branch October 17, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix startup of IOC system tests

2 participants