fix: Remove bitnami common chart and refactor deployment configuration #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
force-pushed
the
no-bitnami
branch
from
60cd5de to
45dc4fc
Compare
DiamondJoseph
force-pushed
the
no-bitnami
branch
from
0d96d84 to
3bbf489
Compare
DiamondJoseph
force-pushed
the
no-bitnami
branch
from
b7d3e80 to
1bd6208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the bitnami common chart, which was being used just to get some of the helper functions already available from the
helm createdefault structure. Additionally refactors the values and use thereof to be more "helmy" and moves config overrides into the values.yaml where they are more exposed and settable.The
opaandbundlerchart now have no requirement on the SealedSecrets that are only available in theauthz-warehousenamespace, and can theoretically be deployed into other namespaces for testing. The SealedSecrets and configuration to make use of the static data have been moved into the Application configuration for the live deployment configuration only.