Skip to content

Create common mirror classes and populate I05s mirrors#1418

Open
Villtord wants to merge 59 commits intomainfrom
common-mirror
Open

Create common mirror classes and populate I05s mirrors#1418
Villtord wants to merge 59 commits intomainfrom
common-mirror

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Jul 31, 2025

Fixes #1424

Instructions to reviewer on how to test:

  1. dodal connect i05, i05-1
  2. Confirm no errors in tests

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.06%. Comparing base (004332f) to head (e4bf584).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1418   +/-   ##
=======================================
  Coverage   99.05%   99.06%           
=======================================
  Files         312      312           
  Lines       11750    11816   +66     
=======================================
+ Hits        11639    11705   +66     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord changed the base branch from main to create-i05-shared-beamline-module July 31, 2025 15:27
Base automatically changed from create-i05-shared-beamline-module to main August 1, 2025 12:55
@Villtord Villtord self-assigned this Aug 4, 2025
Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny comment, take it or leave it

@Villtord
Copy link
Contributor Author

Villtord commented Jan 26, 2026

Merge with main was not trivial - apologies, it's only structural changes, no change in device logic

@Villtord
Copy link
Contributor Author

I should probably move common_mirror.py out of I05 - there might be beamlines with same mirrors that could reuse this code then easier.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some comments in code. Didn't manage to get round to reviewing tests yet though, sorry

@Villtord Villtord requested a review from DominicOram January 30, 2026 10:32
@oliwenmandiamond
Copy link
Contributor

Sorry, this will need to be updated to comply with the new structure of dodal.devices.beamlines.iXX

Copy link
Contributor

@oliwenmandiamond oliwenmandiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for making it comply with the new structure! Just minor formatting change and reuse the defaults and then happy to approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create some common optics mirrors classes and populate I05 optics with them

5 participants

Comments