Skip to content

Use config server for detector LUT#1776

Draft
jacob720 wants to merge 11 commits intomainfrom
mx_bluesky_1509_use_config_server_for_detector_lut
Draft

Use config server for detector LUT#1776
jacob720 wants to merge 11 commits intomainfrom
mx_bluesky_1509_use_config_server_for_detector_lut

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Dec 10, 2025

Fixes DiamondLightSource/mx-bluesky#1509

Required by DiamondLightSource/mx-bluesky#1510

Instructions to reviewer on how to test:

  1. Check detector config is being read through the config server rather than directly from the filesystem

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner December 10, 2025 11:11
@jacob720 jacob720 marked this pull request as draft December 10, 2025 11:11
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (111ce25) to head (1e9a569).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         304      304           
  Lines       11508    11511    +3     
=======================================
+ Hits        11410    11413    +3     
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate detector LUTs to daq config server

1 participant

Comments