Skip to content

I09-1 switch to config_server for hard undulator lut#1798

Open
Villtord wants to merge 33 commits intomainfrom
i09-1-add_lut_from_config_server
Open

I09-1 switch to config_server for hard undulator lut#1798
Villtord wants to merge 33 commits intomainfrom
i09-1-add_lut_from_config_server

Conversation

@Villtord
Copy link
Contributor

@Villtord Villtord commented Dec 18, 2025

This change utilises existing functionality of the config server to read undulator parameters from.
Fixed #1919

Instructions to reviewer on how to test:

  1. Confirm dodal connect i09-1 works.
  2. Confirm tests pass.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Villtord Villtord self-assigned this Dec 18, 2025
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (dffe1f8) to head (6c1dd4a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1798   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         312      312           
  Lines       11749    11764   +15     
=======================================
+ Hits        11638    11653   +15     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Villtord Villtord marked this pull request as ready for review January 20, 2026 11:24
@Villtord Villtord requested a review from a team as a code owner January 20, 2026 11:24
@oliwenmandiamond
Copy link
Contributor

Your i09 devices will be need to be moved to dodal.devices.beamlines.i09_1_shared #1866

@Villtord Villtord marked this pull request as draft February 6, 2026 11:13
@Villtord Villtord marked this pull request as ready for review February 11, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use lookuptable from config server to read hard-x-ray undulator parameters on i09

2 participants

Comments