Implement concrete analyser classes for beamlines to remove generics#1821
Implement concrete analyser classes for beamlines to remove generics#1821oliwenmandiamond wants to merge 37 commits intoanalyser_works_with_blueapifrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## analyser_works_with_blueapi #1821 +/- ##
============================================================
Coverage 99.05% 99.05%
============================================================
Files 312 315 +3
Lines 11730 11784 +54
============================================================
+ Hits 11619 11673 +54
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
to beamline implementation instead.
…sh://github.com/DiamondLightSource/dodal into Implement_concrete_analyser_classes_for_beamlines
Villtord
left a comment
There was a problem hiding this comment.
Nice! Surprisingly it is less code that I expected for moving away from more generics classes.
…sh://github.com/DiamondLightSource/dodal into Implement_concrete_analyser_classes_for_beamlines
Villtord
left a comment
There was a problem hiding this comment.
Thanks, I have just a couple of comments - mainly about class names. Since you refactored analyser classes to be beamline specific, would it make sense to add beamline name in it now? As anyway it is unlikely any other beamline can reuse it due to beamline - specific enums hardcoded in a class.
Also if you decide to rename it I would suggest to use epics names in beamlines - e.g. B07C instead of B071 and so on.
…sh://github.com/DiamondLightSource/dodal into Implement_concrete_analyser_classes_for_beamlines
…alyser_classes_for_beamlines
…alyser_classes_for_beamlines
Remove the generics from the analysers by implementing analyser models for each analyser type. This will also allow for beamline specific behaviour to be later implemented on an analyser.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}