-
Notifications
You must be signed in to change notification settings - Fork 12
Add docstring to synchrotron class #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Villtord
wants to merge
11
commits into
main
Choose a base branch
from
add_synchrotron_docstring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e196daf
add docstring, move name to last parameter, remove extra arbitrary pa…
4d4f1cc
remove attributes from dosctring
7bc05a3
add type hints for all parameters
1a5c024
Merge branch 'main' into add_synchrotron_docstring
Villtord edba8d8
Merge branch 'main' into add_synchrotron_docstring
Villtord 3376109
fix attributes docstring, add args
142bc58
Merge branch 'main' into add_synchrotron_docstring
Villtord 0e2b58b
rewrite attribute docs. add more PVs from GDA beamlines code
05e5ca2
add topup_state attribute docstring
6a7ae5e
Merge branch 'main' into add_synchrotron_docstring
Villtord b30c45b
Merge branch 'main' into add_synchrotron_docstring
Villtord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I always thought having these as arguments was kind of silly. When would we ever change them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably will never change them, but if someone wants to reuse our code in a different synchrotron they would need it. Not that it is difficult to add though... That's the only reasoning I see behind it. But I get a feeling that we don't have such purpose of having this repo reused. Or do we?