Skip to content

Convert p45 beamline to use DeviceManager#1927

Closed
dan-fernandes wants to merge 1 commit intomainfrom
update-p45-to-device-manager
Closed

Convert p45 beamline to use DeviceManager#1927
dan-fernandes wants to merge 1 commit intomainfrom
update-p45-to-device-manager

Conversation

@dan-fernandes
Copy link
Collaborator

Partially fixes ACQP-495

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@dan-fernandes dan-fernandes requested a review from a team as a code owner February 18, 2026 08:30
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (dffe1f8) to head (f8cee12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1927   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files         312      312           
  Lines       11749    11753    +4     
=======================================
+ Hits        11638    11642    +4     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dan-fernandes
Copy link
Collaborator Author

Nevermind - this is covered in #1905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments