Skip to content

Add detector id on jungfrau #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olliesilvester wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −0
Open

Add detector id on jungfrau #1931

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6051ca8
Remove test path provider for i24
olliesilvester Feb 19, 2026
126ffd1
Merge branch 'main' into i24_use_numtracker
olliesilvester Feb 19, 2026
8934414
linting
olliesilvester Feb 19, 2026
2ce4bb4
re-add path provider
olliesilvester Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/dodal/devices/beamlines/i24/commissioning_jungfrau.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
StandardReadable,
TriggerInfo,
observe_value,
soft_signal_r_and_setter,
wait_for_value,
)
from ophyd_async.epics.core import epics_signal_r, epics_signal_rw, epics_signal_rw_rbv
Expand Down Expand Up @@ -110,10 +111,15 @@ def __init__(
writer_prefix: str,
path_provider: PathProvider,
name="",
detector_id=124,
):
self.drv = JungfrauDriverIO(prefix)
writer = JungfrauCommissioningWriter(writer_prefix, path_provider)
controller = JungfrauController(self.drv)
self.ispyb_detector_id, _ = soft_signal_r_and_setter(
int,
initial_value=detector_id,
)
super().__init__(controller, writer, name=name)

@AsyncStatus.wrap
Expand Down