Experimental CMakeLists to build plugin#26
Draft
ndevenish wants to merge 4 commits intoDiamondLightSource:masterfrom
Draft
Experimental CMakeLists to build plugin#26ndevenish wants to merge 4 commits intoDiamondLightSource:masterfrom
ndevenish wants to merge 4 commits intoDiamondLightSource:masterfrom
Conversation
This pulls in it's own copy of HDF5, and builds it strictly statically.
It looks like some configurations have stddef implicitly imported.
The symbols for all of HDF5 causes >10mb bloat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
CMakeLists.txt. It builds it's own copy of static HDF5 1.12 and links it in statically to thedurin-plugin.sofile. TheCMakeLists.txtdoesn't buildtest_pluginorexampleby default in order to match theMakefile, butexamplealso had a header-ordering problem that prevented it being built - this is also fixed in this PR.I don't know how to actually test this plugin.