Skip to content

feat: add start and stop writing top level commands#78

Merged
GDYendell merged 11 commits intomainfrom
75_command_fanout
Nov 20, 2025
Merged

feat: add start and stop writing top level commands#78
GDYendell merged 11 commits intomainfrom
75_command_fanout

Conversation

@shihab-dls
Copy link
Contributor

Closes #75

This PR currently just adds top level start_writing and stop_writing commands, using _filter_sub_controllers and some cached_property's.

This will be rebased over ControllerVector changes in FastCS, and amended, before merging.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.76%. Comparing base (b508374) to head (441feb2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   88.15%   88.76%   +0.60%     
==========================================
  Files          14       14              
  Lines         574      605      +31     
==========================================
+ Hits          506      537      +31     
  Misses         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shihab-dls shihab-dls marked this pull request as ready for review November 18, 2025 15:32
@shihab-dls shihab-dls requested a review from GDYendell November 18, 2025 15:32
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@GDYendell GDYendell changed the title feat: add initial start and stop writing top level commands feat: add start and stop writing top level commands Nov 20, 2025
@GDYendell GDYendell merged commit 6c4da51 into main Nov 20, 2025
19 checks passed
@GDYendell GDYendell deleted the 75_command_fanout branch November 20, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CommandFanoutAttributeIO

2 participants