Open
Conversation
noemifrisina
added
web ui
i24
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
+ Coverage 92.72% 92.74% +0.01%
==========================================
Files 152 154 +2
Lines 8499 8513 +14
==========================================
+ Hits 7881 7895 +14
Misses 618 618
🚀 New features to boost your workflow:
|
olliesilvester
approved these changes
Jan 22, 2026
Contributor
olliesilvester
left a comment
olliesilvester
left a comment
There was a problem hiding this comment.
Added a comment but approved. Maybe let's hold off in merging until I've tested with DiamondLightSource/mx-daq-ui#88
CI failure is unrelated - #1574 should fix it.
Comment on lines
+26
to
+28
| # @pytest.fixture | ||
| # def enum_attenuator() -> EnumFilterAttenuator: | ||
| # return i24.attenuator.build(connect_immediately=True, mock=True) |
Contributor
There was a problem hiding this comment.
Should: Remove comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #151 and #1200
Link to dodal PR (if required): #XXX
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer