Skip to content

Update setup_oav to use plan moved to dodal#1577

Open
noemifrisina wants to merge 4 commits intomainfrom
setup-pin-tip-moved-to-dodal
Open

Update setup_oav to use plan moved to dodal#1577
noemifrisina wants to merge 4 commits intomainfrom
setup-pin-tip-moved-to-dodal

Conversation

@noemifrisina
Copy link
Contributor

The setup_pin_tip_detection_params was moved to dodal in 1858 so that it could be used by non-mx beamlines too. This PR updates setup_oav to use that one.

Instructions to reviewer on how to test:

  1. Check all instances of setup_pin_tip_detection_params have been updated to use the plan in dodal
  2. Run tests

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@noemifrisina noemifrisina requested a review from a team as a code owner January 26, 2026 16:59
@noemifrisina noemifrisina added the dev experience Changes relating to developer experience label Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.71%. Comparing base (b8bbafb) to head (4b7bfa9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
- Coverage   92.72%   92.71%   -0.01%     
==========================================
  Files         152      152              
  Lines        8499     8489      -10     
==========================================
- Hits         7881     7871      -10     
  Misses        618      618              
Components Coverage Δ
i24 SSX 78.56% <ø> (ø)
hyperion 98.20% <ø> (ø)
other 98.27% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just the one issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must: The plan you have removed does not wait at the end but the new one in dodal does by default, can you add wait=False here?

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram enabled auto-merge (squash) January 28, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments