Conversation
* Use protocols instead of smargon type for FGS composite * Rename devices to gonio in all plans * Include generic type everywhere in plan
* Add skip for CI pre-commit for uv lock file update
* Implement robot unload for udc default state
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
=======================================
Coverage 92.86% 92.87%
=======================================
Files 153 153
Lines 8645 8656 +11
=======================================
+ Hits 8028 8039 +11
Misses 617 617
🚀 New features to boost your workflow:
|
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, I've added a few comments
|
|
||
| LOGGER.info(f"Synchrotron beam countdown is {countdown} seconds") | ||
|
|
||
| if countdown < 600: |
There was a problem hiding this comment.
Should: Can you pull this into a constant?
|
|
||
| LOGGER.info(f"Synchrotron beam countdown is {countdown} seconds") | ||
|
|
||
| if countdown < 600: |
There was a problem hiding this comment.
Must: We need to do this check before we start every collection. This is just doing it once when the baton gets handed over
| _raise_udc_completed_alert(get_alerting_service()) | ||
| # Release the baton for orderly exit from the instruction loop | ||
| yield from _unrequest_baton(baton) |
There was a problem hiding this comment.
Could: If we're going to do these two finishing steps together in a few places then we might as well pull them into a new function
| _raise_udc_completed_alert(get_alerting_service()) | ||
| # Release the baton for orderly exit from the instruction loop | ||
| yield from _unrequest_baton(baton) | ||
| raise PlanError("Synchrotron machine countdown too low") |
There was a problem hiding this comment.
Should: I don't think we need to raise here? It's a happy-path operation, like reaching the end of the agamemnon queue
4 participants
Fixes #1601
Requires DiamondLightSource/dodal#1922
Instructions to reviewer on how to test:
Checks for reviewer