Fix system tests caused by zocalo and smargon changes#1628
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1628 +/- ##
=======================================
Coverage 92.81% 92.81%
=======================================
Files 153 153
Lines 8642 8642
=======================================
Hits 8021 8021
Misses 621 621
🚀 New features to boost your workflow:
|
rtuck99
reviewed
Feb 16, 2026
| from mx_bluesky.common.experiment_plans.inner_plans.xrc_results_utils import ( | ||
| zocalo_stage_decorator, | ||
| ) | ||
| from mx_bluesky.common.external_interaction.callbacks.xray_centre.ispyb_callback import ( |
Contributor
There was a problem hiding this comment.
I ran the tests with your change and I'm still getting
File "/scratch/ws/hyperion/mx-bluesky/tests/system_tests/hyperion/external_interaction/callbacks/test_external_callbacks.py", line 256, in test_external_callbacks_handle_gridscan_ispyb_and_zocalo
assert dcid != 0
AssertionError: assert 0 != 0
Contributor
Found it, pushed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the two test failures seen in https://gitlab.diamond.ac.uk/MX-GDA/hyperion-system-testing/-/jobs/319770
Link to dodal PR (if required): #XXX
(remember to update
pyproject.tomlwith the dodal commit tag if you need it for tests to pass!)Instructions to reviewer on how to test:
Checks for reviewer