Skip to content

Fix system tests caused by zocalo and smargon changes#1628

Merged
rtuck99 merged 3 commits intomainfrom
fix_smargon_zocalo_system_tests
Feb 18, 2026
Merged

Fix system tests caused by zocalo and smargon changes#1628
rtuck99 merged 3 commits intomainfrom
fix_smargon_zocalo_system_tests

Conversation

@olliesilvester
Copy link
Contributor

Should fix the two test failures seen in https://gitlab.diamond.ac.uk/MX-GDA/hyperion-system-testing/-/jobs/319770

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@olliesilvester olliesilvester requested a review from a team as a code owner February 12, 2026 15:40
@olliesilvester olliesilvester added the dev experience Changes relating to developer experience label Feb 12, 2026
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.81%. Comparing base (e122b0b) to head (e4fba12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1628   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files         153      153           
  Lines        8642     8642           
=======================================
  Hits         8021     8021           
  Misses        621      621           
Components Coverage Δ
i24 SSX 78.60% <ø> (ø)
hyperion 98.22% <ø> (ø)
other 98.22% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 self-assigned this Feb 16, 2026
from mx_bluesky.common.experiment_plans.inner_plans.xrc_results_utils import (
zocalo_stage_decorator,
)
from mx_bluesky.common.external_interaction.callbacks.xray_centre.ispyb_callback import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the tests with your change and I'm still getting

  File "/scratch/ws/hyperion/mx-bluesky/tests/system_tests/hyperion/external_interaction/callbacks/test_external_callbacks.py", line 256, in test_external_callbacks_handle_gridscan_ispyb_and_zocalo
    assert dcid != 0
AssertionError: assert 0 != 0

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still get the test failure even with #1627 merged, will approve this and investigate why that is still happening

@rtuck99
Copy link
Contributor

rtuck99 commented Feb 18, 2026

Still get the test failure even with #1627 merged, will approve this and investigate why that is still happening

Found it, pushed commit

@rtuck99 rtuck99 enabled auto-merge (squash) February 18, 2026 10:40
@rtuck99 rtuck99 merged commit 6520e6e into main Feb 18, 2026
15 checks passed
@rtuck99 rtuck99 deleted the fix_smargon_zocalo_system_tests branch February 18, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments