Skip to content

Add vmxm gridscan plan#1636

Open
olliesilvester wants to merge 4 commits into364_make_nexus_callbacks_genericfrom
add_vmxm_gridscan_plan
Open

Add vmxm gridscan plan#1636
olliesilvester wants to merge 4 commits into364_make_nexus_callbacks_genericfrom
add_vmxm_gridscan_plan

Conversation

@olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented Feb 18, 2026

Requires #1623 and DiamondLightSource/dodal#1925
Supersedes #924 and #1214

Note that these gridscans don't have ispyb integration. That is coming in a later PR

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@olliesilvester olliesilvester changed the base branch from main to 364_make_nexus_callbacks_generic February 18, 2026 17:24
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 92.68293% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (a31185d) to head (4bce4b2).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           364_make_nexus_callbacks_generic    #1636   +/-   ##
=================================================================
  Coverage                             92.78%   92.78%           
=================================================================
  Files                                   153      156    +3     
  Lines                                  8671     8757   +86     
=================================================================
+ Hits                                   8045     8125   +80     
- Misses                                  626      632    +6     
Components Coverage Δ
i24 SSX 78.60% <ø> (ø)
hyperion 98.22% <ø> (ø)
other 97.99% <92.68%> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester olliesilvester marked this pull request as ready for review February 18, 2026 18:34
@olliesilvester olliesilvester requested a review from a team as a code owner February 18, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments