Conversation
lab2.sql
Outdated
| SELECT * | ||
| FROM "HR"."Employees" | ||
| WHERE city = 'London' | ||
| AND (title LIKE '%Manager%' OR title ILIKE '%manager%') |
Collaborator
There was a problem hiding this comment.
Зачем 2 лайка? like и ilike????
lab2.sql
Outdated
| WHERE city = 'London' | ||
| AND (title LIKE '%Manager%' OR title ILIKE '%manager%') | ||
| AND (titleofcourtesy = 'Dr.' | ||
| OR LOWER(titleofcourtesy) LIKE 'mr%'); |
Collaborator
There was a problem hiding this comment.
LOWER(titleofcourtesy) - это вычисляемый столбец, а не исходный.
Мы договаривались, что фильтрация должна выполняться на исходных данных
lab2.sql
Outdated
| WHERE contactname NOT LIKE '%Linda%' | ||
| AND contactname NOT LIKE '%Robert%' | ||
| AND contactname NOT LIKE '%Ann%' | ||
| AND contactname NOT LIKE '%Venky%'; |
Collaborator
There was a problem hiding this comment.
4!!! Условия!!!
Перепишите фильтр, чтобы было одно условия
Тем более, что ваш фильтр не корректен: '%Ann%' - вы отфильтруете и Annett-у
lab2.sql
Outdated
| OR SUBSTRING(TRIM(SUBSTRING(contactname FROM POSITION(',' IN contactname) + 1)) FROM 1 FOR 1) = 'M') | ||
| AND | ||
| (SUBSTRING(TRIM(SUBSTRING(contactname FROM 1 FOR POSITION(',' IN contactname) - 1)) FROM 1 FOR 1) = 'S' | ||
| OR SUBSTRING(TRIM(SUBSTRING(contactname FROM 1 FOR POSITION(',' IN contactname) - 1)) FROM 1 FOR 1) = 'K'); |
Collaborator
There was a problem hiding this comment.
Одно условие на исходном столбце!!! А не куча условий на вычисляемых столбцах :(((
Collaborator
ksigorodetskaya
left a comment
ksigorodetskaya
left a comment
There was a problem hiding this comment.
Внести исправления в соответствие с замечаниями
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.