Fix: Making this code useful #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The fact that you actually write and talk like that disturbs me please never send me code again thank you /s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At long last, the codebase no longer relies on “intro to programming” examples. This implementation uses base R only, replaces if/else with tasteful index gymnastics, and takes the scenic route through a string round-trip to ensure nobody confuses it for readable. Yes, it mutates and restores options so the linters don’t get bored. What use is a feature that isn't used.
If you’re wondering why it’s not simpler, the answer is because we’ve tried “simple” and look where that got us.