Converted project to netstandard2.0

[JordanVanGogh]

Converted the Saml project to.NET Standard 2.0 for us who moved to .NET Core.

In addition to that: reapplied fix for this issue: jitbit#9

[martin-displayr]

Hi Jordan, thanks for taking the time, and sending me this.

Can you tell me more about this change. It looks like you removed a lot of stuff from assemblyinfo.cs / csproj. If it passes the tests I am inclined to accept it.

Is there any kind of unit or integration test we can run to assert that the project is .NET Standard compatible?

[JordanVanGogh]

The .NET Standard and .NET Core project files are much leaner than their .NET Framework counterpart. A lot of it is now decided by convention, which reduces the project files significantly in size. For reference see: https://www.hanselman.com/blog/UpgradingAnExistingNETProjectFilesToTheLeanNewCSPROJFormatFromNETCore.aspx

Most of the information that used to be placed in Assembly attributes, should now be defined in the project files.

I don't think it is necessary (or feasable) to define new tests to assert .NET Standard compatability. If the currently available tests (which are contained in .NET Framework 4.6.1 projects) run without problems, it implicitly asserts compatability with .NET Standard.

[martin-displayr]

Hi Jordan, OK I am happy to merge this. There is an issue with our CI pipeline, so once that is fixed and this PR passes I will merge it in and publish a new Nuget package. Thanks for your help.

[martin-displayr]

Hi Jordan. I have now fixed the Appveyor/CI issues on master and that is passing. When I merge this in I get a failing test for the TestInvalidXML test:

Message: Test method Saml.Test.TestResponseClassSaml.TestInvalidXml threw exception: 
System.IO.FileLoadException: Could not load file or assembly 'System.Security.Cryptography.Xml, Version=4.0.1.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

I'll look into it deeper when I get time, but if you have any ideas on how to fix this, please let me know.

[JordanVanGogh]

Hi Martin,

Sorry for the late reply (easter holiday). I will investigate the error in the coming weekend, and I'll let you know.

Regards.