Skip to content

Conversation

@Magitron
Copy link
Contributor

@Magitron Magitron commented Oct 13, 2017

  • add create-project button component
  • fix layout in profile
  • added username to profile header

This is the PR where I'm getting the error

Method “props” is only meant to be run on a single node. 0 found instead.

And also

Failed prop type: The prop `userName` is marked as required in `Profile`, but its value is `undefined`.

when I run the tests

@Magitron Magitron requested a review from mikenikles October 13, 2017 11:10
@Magitron Magitron self-assigned this Oct 13, 2017
@mikenikles
Copy link

The first error you see is a bug in the code. For some reason, our anchor tags don't render a href attribute. It's most likely because we have this concept:

<Link>
  <SomeStyledComponentWhichIsAnAnchorTag />
</Link>

I will have to look at the source code of the packages we use to see what's going on.

The warning you saw about the missing userName prop is fixed in 018c9b3.

type: 'test-project-type',
user: {}
user: {
name: 'Test User'
Copy link
Contributor Author

@Magitron Magitron Oct 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, okay. Thanks @mikenikles!

@Magitron
Copy link
Contributor Author

Magitron commented Jan 25, 2018

If you click on the avatar from the home page it works, check there.
The link component needs an anchor tag child

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants