Feature/css grid exercise raul valencia #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushdev-code
suggested changes
May 19, 2020
| @@ -0,0 +1,34 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
don't include this file. Always create your new branches by being on master.
4-css-grid/styles.css
Outdated
| @@ -0,0 +1,18 @@ | |||
| * section { | |||
There was a problem hiding this comment.
Suggested change
| * section { | |
| .section { |
Prefer classnames over tagnames so your markup doesn't have to match your styles.
4-css-grid/styles.css
Outdated
| padding: 20px; | ||
| } | ||
| body { | ||
| display: grid; |
There was a problem hiding this comment.
don't apply this directly to the body, use a wrapper. If you do this and you want to include another element which is not a grid, you will have to deal with display issues.
4-css-grid/styles.css
Outdated
| display: grid; | ||
| grid-template: 50% 50% / 1fr 1fr 1fr; | ||
| } | ||
| section:first-child { |
There was a problem hiding this comment.
cool, you got the child pseudo selectors, but prefer classnames so your markup doesn't have to match your styles.
Collaborator
|
Please fix the conflicts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New exercise