fix: animated url logic #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isAnimatedUrl` function was previously using `endsWith` to check for animated image extensions. This failed for URLs that contained query parameters. The function has been updated to use `substringBefore("?")` to remove any query parameters before checking the extension, ensuring that animated images are correctly identified.
dragonx943
reviewed
Nov 10, 2025
| fun String.isHttpUrl() = startsWith("https://", ignoreCase = true) || startsWith("http://", ignoreCase = true) | ||
|
|
||
| fun String.isAnimatedImage() = endsWith(".gif", ignoreCase = true) || endsWith(".webp", ignoreCase = true) | ||
| fun String.isAnimatedImage() = substringBefore("?").run { endsWith(".gif", ignoreCase = true) || endsWith(".webp", ignoreCase = true) } |
Member
There was a problem hiding this comment.
use contains ?
and not all webp is animated, it can be static too
Member
There was a problem hiding this comment.
should add function to check webp images
dragonx943
pushed a commit
that referenced
this pull request
Nov 12, 2025
The `isAnimatedUrl` function was previously using `endsWith` to check for animated image extensions. This failed for URLs that contained query parameters. The function has been updated to use `substringBefore("?")` to remove any query parameters before checking the extension, ensuring that animated images are correctly identified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isAnimatedUrlfunction was previously usingendsWithto check for animated image extensions. This failed for URLs that contained query parameters. The function has been updated to usesubstringBefore("?")to remove any query parameters before checking the extension, ensuring that animated images are correctly identified.