Skip to content

unique_test_names: Don't seed the table #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DolceTriade merged 1 commit into from
Nov 21, 2025
Merged

unique_test_names: Don't seed the table #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions blade/db/postgres/migrations/2025-11-19-000000_unique_test_names/up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ CREATE TABLE IF NOT EXISTS unique_test_names (
-- Create GIN index on name for LIKE '%pattern%' searches
CREATE INDEX IF NOT EXISTS unique_test_names_trgm_idx ON unique_test_names USING GIN (name gin_trgm_ops);

-- Seed the table with existing test names from tests table
INSERT INTO unique_test_names (name)
SELECT DISTINCT name FROM tests
ON CONFLICT (name) DO NOTHING;

-- Create trigger function to maintain unique_test_names when tests table changes
CREATE OR REPLACE FUNCTION maintain_unique_test_names()
RETURNS TRIGGER AS $$
Expand Down
4 changes: 0 additions & 4 deletions blade/db/sqlite/migrations/2025-11-19-000000_unique_test_names/up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ CREATE TABLE IF NOT EXISTS unique_test_names (
-- Create index on name for LIKE '%pattern%' searches
CREATE INDEX IF NOT EXISTS unique_test_names_idx ON unique_test_names (name);

-- Seed the table with existing test names from tests table
INSERT OR IGNORE INTO unique_test_names (name)
SELECT DISTINCT name FROM tests;

-- Create trigger function to maintain unique_test_names when tests table changes
-- SQLite uses INSTEAD OF triggers for insert/update/delete, but since we're triggering AFTER,
-- we need separate triggers for each operation.
Expand Down