Skip to content

hide icon for long root errors using css container query with flex wrap solution #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshunrau merged 2 commits into from
Jan 14, 2026
Merged

hide icon for long root errors using css container query with flex wrap solution #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b905a
fix: prevent icon in error message shrinking
joshunrau Jan 14, 2026
661ae9e
fix: hide icon for long root errors using css container query with fl…
joshunrau Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions src/components/Form/ErrorMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,37 @@ import { CircleAlertIcon } from 'lucide-react';

import { cn } from '@/utils';

export const ErrorMessage: React.FC<{ className?: string; error?: null | string[] }> = ({ className, error }) => {
return error ? (
export const ErrorMessage: React.FC<{ className?: string; error?: null | string[]; hideIconOnWrap?: boolean }> = ({
className,
error,
hideIconOnWrap
}) => {
if (!error) {
return null;
}
return (
<div className="flex flex-col gap-1.5">
{error.map((message) => (
<div className={cn('text-destructive flex w-full items-center text-sm font-medium', className)} key={message}>
<CircleAlertIcon className="mr-1" style={{ strokeWidth: '2px' }} />
<span data-testid="error-message-text">{message}</span>
<div
className={cn(
'text-destructive flex w-full items-center text-sm font-medium',
hideIconOnWrap && 'flex-wrap',
className
)}
key={message}
>
<div className="@container/alert mr-1.5 flex min-w-4 shrink-0 flex-grow-[1] items-center justify-start">
<div className="h-0 w-0" />
<CircleAlertIcon
className="@min-[24px]/alert:hidden"
style={{ height: '16px', strokeWidth: '2px', width: '16px' }}
/>
</div>
<span className="flex-grow-[999]" data-testid="error-message-text">
{message}
</span>
</div>
)) ?? null}
))}
</div>
) : null;
);
};
6 changes: 5 additions & 1 deletion src/components/Form/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,11 @@ const Form = <TSchema extends ZodTypeLike<FormDataType>, TData extends TSchema['
values={values}
/>
)}
{Boolean(rootErrors.length) && <ErrorMessage className="-mt-3" error={rootErrors} />}
{Boolean(rootErrors.length) && (
<div className="-mt-3">
<ErrorMessage hideIconOnWrap error={rootErrors} />
</div>
)}
{fieldsFooter}
<div className="flex w-full gap-3">
{additionalButtons?.left}
Expand Down