Add PebbleKit JavaScript settings page to Revolution watchface #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks very promising! Could you rebase your commits into one commit or at least multiple more logical commits? I'll test it out sometime this week and most likely merge it. |
Author
|
Done! Note most of the appinfo changes are due to me importing the project into CloudPebble which refactored things I think. I also removed some trailing whitespace in Revolution.c. |
Owner
|
Yeah, there are some code style things I'll have to change, but on the whole it looks great. Thanks a lot :) |
Author
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new settings page allows you to select American date format, vibrate on the hour, invert watchface colors, and choose between displaying year and seconds. Note that the current code requires the watchface to be reloaded before changes take effect.
Screenshot:
PBW file:
https://builds.cloudpebble.net/53958ad8-602c-44ac-9155-3a45d83a9e29/watchface.pbw