fix(syscall): 修复一些系统调用 #1622
fix(syscall): 修复一些系统调用 #1622
Conversation
github-actions
bot
added
Bug fix
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if how.o_flags.contains(FileFlags::O_NOFOLLOW) && file_type == FileType::SymLink { | ||
| return Err(SystemError::ELOOP); | ||
| } |
There was a problem hiding this comment.
O_NOFOLLOW check ignores O_PATH flag combination
Medium Severity
When O_PATH | O_NOFOLLOW are both set, Linux semantics dictate that open() should succeed and return an O_PATH file descriptor referencing the symbolic link itself. However, the new check unconditionally returns ELOOP when O_NOFOLLOW is set and the target is a symlink, breaking this valid use case. The check needs to exclude the case where O_PATH is also present in o_flags.
xboHodx
changed the title
github-actions
bot
added
the
ambiguous
xboHodx
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3284ad11b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kernel/src/filesystem/vfs/open.rs
Outdated
| if how.o_flags.contains(FileFlags::O_NOFOLLOW) && file_type == FileType::SymLink { | ||
| return Err(SystemError::ELOOP); |
There was a problem hiding this comment.
The new unconditional O_NOFOLLOW && symlink => ELOOP check blocks openat calls that intentionally use O_PATH|O_NOFOLLOW to obtain a file descriptor for the symlink itself (Linux allows this and it is the standard way to later fstatat(AT_EMPTY_PATH|AT_SYMLINK_NOFOLLOW) the link). With this change, such calls now fail even though the caller explicitly requested a path-only FD, which breaks symlink-introspection use cases while not required to satisfy the OpenNoFollowSymlink test for non-O_PATH opens.
Useful? React with 👍 / 👎.
feat(time): 增加系统启动时间和运行时间的计算 fix(process): 添加获取当前进程数量的函数
|
bugbot run |
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
github-actions
bot
removed
the
ambiguous
2 participants
Uh oh!
There was an error while loading. Please reload this page.