Open
Conversation
a1cd
suggested changes
Sep 10, 2023
Contributor
a1cd
left a comment
a1cd
left a comment
There was a problem hiding this comment.
I made a bunch of comments. They have suggestions you can easily approve if you want to but make sure to read them first
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/Manipulator.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/commands/manipulator/SetManipulatorSpeed.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Show resolved
Hide resolved
| private final RelativeEncoder encoder; | ||
| private final SparkMaxPIDController pid; | ||
|
|
||
| public ManipulatorIOSparkMax(){ |
Contributor
There was a problem hiding this comment.
if you want you can make motor id a parameter, but it will work this way as well
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIO.java
Outdated
Show resolved
Hide resolved
Open
Co-authored-by: Everett Wilber <71281043+a1cd@users.noreply.github.com>
Co-authored-by: Everett Wilber <71281043+a1cd@users.noreply.github.com>
a1cd
suggested changes
Sep 12, 2023
src/main/java/frc/robot/commands/manipulator/SetManipulatorSpeed.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIOSparkMax.java
Show resolved
Hide resolved
Quick simple compilation failures
a1cd
reviewed
Sep 12, 2023
src/main/java/frc/robot/subsystems/manipulator/ManipulatorIO.java
Outdated
Show resolved
Hide resolved
a1cd
approved these changes
Sep 12, 2023
Contributor
a1cd
left a comment
a1cd
left a comment
There was a problem hiding this comment.
Nice effort, still untested code and it is not used in robot container but it looks like it should work properly.
Contributor
|
@Ryan-Bauroth Merge it when you want to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can someone make sure all this code looks good? I think it all should work but I am unsure about the init() function and just general IO things being correct. Thanks!